Added generation of strongly typed http client on build #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TTA777
commented
Apr 15, 2024
•
TTA777
commented
- Removed project for manual generation of client
- Removed auto generated code from repo
- AnalogCore clients are now automatically generated on build
- Removed project for manual generation of client - AnalogCore clients are now automatically generated on build
TTA777
force-pushed
the
feature/auto-generated-http-client
branch
from
44613b8 to
c26d14c
Compare
A-Guldborg
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
LGTM
As discussed: We could consider ensuring that dev deployment always targets current analog-core dev version, and production deployment always targets current analog-core prd version. But for now this is good.
I am wondering if a breaking change from core would cause shifty would break until the swagger is updated, but we are luckily the same people working on both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.