adding logging around asset uploading.

AnalogJ · Jul 26, 2017 · 6fba217 · 6fba217
1 parent b227001
commit 6fba217
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/pkg/pipeline.go b/pkg/pipeline.go
@@ -198,9 +198,7 @@ func (p *Pipeline) PostScmInit()                      { p.RunHook("scm_init_step
 func (p *Pipeline) PreScmRetrievePayload()            { p.RunHook("scm_retrieve_payload_step.pre") }
 func (p *Pipeline) PostScmRetrievePayload()           { p.RunHook("scm_retrieve_payload_step.post") }
 func (p *Pipeline) PreScmCheckoutPullRequestPayload() { p.RunHook("scm_checkout_pull_request_step.pre") }
-func (p *Pipeline) PostScmCheckoutPullRequestPayload() {
-	p.RunHook("scm_checkout_pull_request_step.post")
-}
+func (p *Pipeline) PostScmCheckoutPullRequestPayload() { p.RunHook("scm_checkout_pull_request_step.post") }
 func (p *Pipeline) PreScmCheckoutPushPayload()  { p.RunHook("scm_checkout_push_payload_step.pre") }
 func (p *Pipeline) PostScmCheckoutPushPayload() { p.RunHook("scm_checkout_push_payload_step.post") }
 func (p *Pipeline) PreScmPublish()              { p.RunHook("scm_publish_step.pre") }

diff --git a/pkg/scm/scm_github.go b/pkg/scm/scm_github.go
@@ -279,7 +279,11 @@ func (g *scmGithub) Publish() error {
 		return rerr
 	}
 
-	g.PublishAssets(releaseData.GetID())
+	if perr := g.PublishAssets(releaseData.GetID()); perr != nil{
+		log.Print("An error occured while publishing assets:")
+		log.Print(perr)
+		log.Print("Continuing...")
+	}
 
 	return nil
 }
@@ -359,10 +363,12 @@ func (g *scmGithub) Notify(ref string, state string, message string) error {
 
 //private
 
-func publishAsset(client *github.Client, ctx context.Context, repoOwner, repoName, assetName, filePath string, releaseID, retries int) error {
+func publishAsset(client *github.Client, ctx context.Context, repoOwner string, repoName string, assetName, filePath string, releaseID, retries int) error {
 
+	log.Printf("Attempt (%s) to upload release asset %s from %s", retries, assetName, filePath)
 	f, err := os.Open(filePath)
 	if err != nil {
+		log.Print(err)
 		return err
 	}