add a new test for getLatestTag.

AnalogJ · Jul 22, 2017 · b0cb910 · b0cb910
1 parent c7b5145
commit b0cb910
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/pkg/utils/git.go b/pkg/utils/git.go
@@ -20,8 +20,10 @@ type GitTagDetails struct {
 	CommitDate   time.Time
 }
 
+// Clone a git repo into a local directory.
+// Credentials need to be specified by embedding in gitRemote url.
+// TODO: this pattern may not work on Bitbucket/GitLab
 func GitClone(parentPath string, repositoryName string, gitRemote string) (string, error) {
-	//TODO: credentials may need to be specified
 	absPath, aerr := filepath.Abs(path.Join(parentPath, repositoryName))
 	if aerr != nil {
 		return "", aerr

diff --git a/pkg/utils/git_test.go b/pkg/utils/git_test.go
@@ -246,6 +246,20 @@ func TestGitLatestTaggedCommit(t *testing.T) {
 
 }
 
+func TestGitLatestTaggedCommit_InvalidDirectory(t *testing.T) {
+	t.Parallel()
+
+	//setup
+	dirPath := path.Join("this", "path", "does", "not", "exist")
+
+	//test
+	tag, ferr := utils.GitLatestTaggedCommit(dirPath)
+
+	//assert
+	require.Error(t, ferr)
+	require.Empty(t, tag)
+}
+
 func TestGitGenerateChangelog(t *testing.T) {
 	t.Parallel()