Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated valid record types for DreamHost integration #1110

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

JerrettDavis
Copy link
Contributor

Currently, the DreamHost integration only recognizes A and AAAA records as valid for determining the validity of a domain. To be consistent with the other integrations in the repository, I updated the integration to check for the following record types: A, AAAA, CNAME, MX, NS, SOA, TXT, and SRV

@JerrettDavis
Copy link
Contributor Author

Per issue #1064

Copy link
Contributor

@chhsiao1981 chhsiao1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adferrand
Copy link
Collaborator

Thanks !

@adferrand adferrand merged commit b1fe3fb into AnalogJ:master Feb 13, 2022
MasinAD pushed a commit to MasinAD/lexicon that referenced this pull request Mar 29, 2022
* Updated valid record types for dreamhost integration

* Forgot remaining
MasinAD pushed a commit to MasinAD/lexicon that referenced this pull request Mar 29, 2022
* Updated valid record types for dreamhost integration

* Forgot remaining
MasinAD pushed a commit to MasinAD/lexicon that referenced this pull request Mar 29, 2022
* Updated valid record types for dreamhost integration

* Forgot remaining
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants