Exclude integration tests from source distributions + remove MANIFEST.in #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cassettes aren't included so these tests have no value.
|
Otherwise, you could ship cassettes in PyPI tarballs. They add about 7 MiB. Too bad we can't do XZ because a complete source snapshot compressed with XZ is only 704 KiB. |
|
Ok, let's clear these tests indeed. Thanks! |
MasinAD
pushed a commit
to MasinAD/lexicon
that referenced
this pull request
Mar 29, 2022
….in (AnalogJ#909) * Exclude integration tests from source distributions Cassettes aren't included so these tests have no value. * Remove MANIFEST.in, poetry handles included and excluded files Co-authored-by: Adrien Ferrand <ferrand.ad@gmail.com>
MasinAD
pushed a commit
to MasinAD/lexicon
that referenced
this pull request
Mar 29, 2022
….in (AnalogJ#909) * Exclude integration tests from source distributions Cassettes aren't included so these tests have no value. * Remove MANIFEST.in, poetry handles included and excluded files Co-authored-by: Adrien Ferrand <ferrand.ad@gmail.com>
MasinAD
pushed a commit
to MasinAD/lexicon
that referenced
this pull request
Mar 29, 2022
….in (AnalogJ#909) * Exclude integration tests from source distributions Cassettes aren't included so these tests have no value. * Remove MANIFEST.in, poetry handles included and excluded files Co-authored-by: Adrien Ferrand <ferrand.ad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since cassettes aren't included in sdists, these tests aren't very useful. I am also removing MANIFEST.in which is unused as far as I can tell.