Fix invalid API request to Rackspace Cloud DNS - Issue #981 #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnalogJ This is my first time contributing to this repository, please let me know if there are any guidelines I missed, or changes I need to make. Best, |
|
@adferrand I'm mentioning you in the PR since it appears you've been more active recently. Right now the Rackspace provider is broken in the current release. If you have time, please look over this PR and tell me if there is anything I need to update or change. Best, |
|
No I have everything needed. You fixed the issue and the integration tests still work, proving that the fix has no known side effect. I merge and prepare a new release. Thanks a lot! |
mattgauf
deleted the
bugfix/issue-981-invalid-api-request-to-rackspace
branch
MasinAD
pushed a commit
to MasinAD/lexicon
that referenced
this pull request
Mar 29, 2022
…nalogJ#989) * Solution for Issue AnalogJ#981. Update _request method for Rackspace Cloud * Add @mattgauf to CODEOWNERS for Rackspace
MasinAD
pushed a commit
to MasinAD/lexicon
that referenced
this pull request
Mar 29, 2022
…nalogJ#989) * Solution for Issue AnalogJ#981. Update _request method for Rackspace Cloud * Add @mattgauf to CODEOWNERS for Rackspace
MasinAD
pushed a commit
to MasinAD/lexicon
that referenced
this pull request
Mar 29, 2022
…nalogJ#989) * Solution for Issue AnalogJ#981. Update _request method for Rackspace Cloud * Add @mattgauf to CODEOWNERS for Rackspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #981 invalid API request to Rackspace Cloud DNS.
Rackspace's API returns 403 for GET requests that include a request body. After reviewing my original solution (mentioned in the linked issue), I determined that a better solution was possible.
My decision-making process was:
datato an empty literal at the start of the method for consistency with expected bahvior.json.dumps()inline at the data argument to ensure that all requests that send a JSON payload are parsed.None. (Requests library omits request body when the value isNonetype.)I also added myself to the CODEOWNERS file after reviewing the developer guide. If I missunderstood the purpose of CODEOWNERS then please feel free to remove me.