Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Make fonts self-hostable #125

Closed
djmattyg007 opened this issue Dec 7, 2020 · 5 comments · Fixed by #263
Closed

[FEAT] Make fonts self-hostable #125

djmattyg007 opened this issue Dec 7, 2020 · 5 comments · Fixed by #263
Labels
enhancement New feature or request

Comments

@djmattyg007
Copy link

Is your feature request related to a problem? Please describe.
Right now, if you don't have internet access for some reason, the custom fonts used in the web dashboard won't work. This isn't great for a self-hostable piece of software.

Describe the solution you'd like
As per this blog post, there is now essentially zero benefit to using Google Fonts assets directly:

https://wicki.io/posts/2020-11-goodbye-google-fonts/

Therefore, ideally the fonts would just be self-hosted. For those running the dashboard behind a HTTP/2 proxy (like Nginx), the loading performance should improve. It will also make this usable in offline scenarios.

@AnalogJ
Copy link
Owner

AnalogJ commented Dec 19, 2020

Hey @djmattyg007 that's a good idea. Any chance you'd be willing to take on this work and open a PR?

@djmattyg007
Copy link
Author

Absolutely! I'll let you know how I go with it.

@djmattyg007
Copy link
Author

Is the Roboto font actually used? The only font-family property I could see that included it also includes Inter. Inter is specified with a higher precedence than Roboto, and Inter is already self-hosted, so I don't think Roboto actually gets used at all.

@Wdavery
Copy link

Wdavery commented May 26, 2022

Would like to give this a boost. I just experienced a prolonged power outage, and when I did get power back to my server, I was without internet for many days. My go-to drive health monitor is Scrutiny, so not being able to use it offline was a bummer.
Would love to see this fully usable without an internet connection.

AnalogJ added a commit that referenced this issue May 26, 2022
@AnalogJ AnalogJ added the enhancement New feature or request label May 26, 2022
@AnalogJ
Copy link
Owner

AnalogJ commented May 28, 2022

fixed in v0.4.8 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants