Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Unable to delete disk with no data #314

Closed
adhawkins opened this issue Jun 26, 2022 · 6 comments · Fixed by #328
Closed

[BUG] Unable to delete disk with no data #314

adhawkins opened this issue Jun 26, 2022 · 6 comments · Fixed by #328
Labels
bug Something isn't working

Comments

@adhawkins
Copy link

Describe the bug
While setting up on my Synology NAS, I initially had it scan all 8 bays, even though there weren't 8 disks in it. This has led to an empty entry for /dev/sata8. If I use the 'Delete Device' option on the menu for this device, when the confirmation dialog comes up, pressing 'delete' does nothing.

Expected behavior
Pressing 'delete' should delete the device'

Screenshots

image

image

Version is shown as 'master#eefdc54'
@adhawkins adhawkins added the bug Something isn't working label Jun 26, 2022
@AnalogJ
Copy link
Owner

AnalogJ commented Jun 27, 2022

thats odd. @adhawkins can you zip up your config directory and email it to me at jason@thesparktree.com? Thanks!

@adhawkins
Copy link
Author

Done.

@AnalogJ
Copy link
Owner

AnalogJ commented Jul 10, 2022

Hey @adhawkins
I finally had time to look at the db backup you provided, and it looks like the device unique identifier is blank for one of your disks, which would explain why scrutiny can't delete it.

I thought I fixed this in an earlier version, but it looks like there's a related in another function.

AnalogJ added a commit that referenced this issue Jul 10, 2022
@AnalogJ
upgrading to go 1.18 for generics (and lodash-like library).
5ea149d 
devices with an empty wwn should be filtered out (not uploaded during device registration, skipped when attempting to upload metrics).
added a migration to delete existing device entries with an empty `wwn`

fixes #314
@AnalogJ AnalogJ mentioned this issue Jul 10, 2022
Merged
@adhawkins
Copy link
Author

Hey @adhawkins I finally had time to look at the db backup you provided, and it looks like the device unique identifier is blank for one of your disks, which would explain why scrutiny can't delete it.

I thought I fixed this in an earlier version, but it looks like there's a related in another function.

Thanks for taking a look. I assume at some point there'll be a release that contains this fix? Will give it a try then.

@AnalogJ
Copy link
Owner

AnalogJ commented Jul 10, 2022

yep, I fixed it in the beta branch. Basically I added extra code to ensure that empty disk identifiers are filtered out, and a database migration that deletes any existing disks with an empty identifier.

It'll be available in the v0.4.16 release.

@tdehaeze
Copy link

Still have the same issue with last version #ee893cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pre v0.4.16 AnalogJ/scrutiny
3 participants
@AnalogJ @adhawkins @tdehaeze