Add settings for dark mode #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is great, thanks for the PR! 🎉 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @AnalogJ a "dark mode" theme already exists so this PR just adds a UI to use it and makes a couple tweaks to colors.
I didnt want to be too opinionated about changing colors, I tried to respect the choices you made (with the exception of the yellow background which is just too bright for dark mode so went with a gray).
Screenshots below, theres a toggle to just "use system settings" which is enabled by default. If thats disabled the user can specify the theme light / dark.
Of course please let me know if you notice any issues!
Fixes #268