Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permissions setting in Dockerfile.web #520

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

kaysond
Copy link
Contributor

@kaysond kaysond commented Sep 29, 2023

This fixes issues with assets loading when you run as non root users

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This fixes issues with assets loading when you run as non root users
@codecov-commenter
Copy link

Codecov Report

Merging #520 (a8621d2) into master (0febe3f) will decrease coverage by 1.80%.
Report is 66 commits behind head on master.
The diff coverage is 1.81%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   32.54%   30.74%   -1.80%     
==========================================
  Files          54       29      -25     
  Lines        3045     2709     -336     
  Branches       66        0      -66     
==========================================
- Hits          991      833     -158     
+ Misses       2018     1846     -172     
+ Partials       36       30       -6     
Flag Coverage Δ
unittests 30.74% <1.81%> (-1.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webapp/backend/pkg/web/server.go 62.26% <100.00%> (-4.41%) ⬇️
webapp/backend/pkg/config/config.go 0.00% <0.00%> (ø)
webapp/backend/pkg/notify/notify.go 35.39% <0.00%> (-0.37%) ⬇️
...end/pkg/database/scrutiny_repository_migrations.go 0.00% <0.00%> (ø)
webapp/backend/pkg/database/scrutiny_repository.go 11.65% <0.00%> (-0.96%) ⬇️

... and 25 files with indirect coverage changes

@AnalogJ
Copy link
Owner

AnalogJ commented Oct 17, 2023

Thanks for the PR 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants