Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike for static pre-rendering with Lit SSR #4

Closed
wants to merge 2 commits into from

Conversation

thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented Feb 12, 2022

Related Issue

Exploring enhancements and workflows related to SSR with Greenwood like:

  • Static pre-rendering and entire site with lit (instead of using puppeteer)
  • Client side hydration (as it seems without data-gwd-opt="static" footer renders twice?)
  • Can custom resource plugins (import CSS, JSON) work on the server side?

Summary of Changes

  1. Basic footer / header / banner example with Lit static pre-rendering

TODO

  1. This approach doesn't even work with FF / Safari though? I would have figured at the least the static markup would come through, even if not all the styles? There is a polyfill but that does not seem to work?
  2. Investigate double HTML render - Cannot reproduce?
    • do we need to involve hydration, e.g. @lit-labs/ssr-client
    • or is data-gwd-opt="static" a sufficient option?
  3. Hydration testing / support - add support for (progressive) hydration for compatible renderers (globalThis for state?) ProjectEvergreen/greenwood#880
  4. meta HTML is being exported twice in public/index.html (or default app.html is being used and merged?)
  5. Is puppeteer still running for yarn build, or just the devServer?

@netlify
Copy link

netlify bot commented Feb 12, 2022

✔️ Deploy Preview for laughing-kare-be3077 ready!

🔨 Explore the source changes: 04299a3

🔍 Inspect the deploy log: https://app.netlify.com/sites/laughing-kare-be3077/deploys/621bb49859380100075a03b0

😎 Browse the preview: https://deploy-preview-4--laughing-kare-be3077.netlify.app/

@thescientist13 thescientist13 changed the title basic footer example spike for static pre-rendering with Lit SSR Feb 12, 2022
@thescientist13
Copy link
Contributor Author

not going to do this with Lit, will do it with WCC / HTMLElement instead.

@thescientist13 thescientist13 deleted the spike-static-lit-prerendering branch October 24, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant