Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 21 home page #49

Merged
merged 9 commits into from
Oct 24, 2022
Merged

Feature/issue 21 home page #49

merged 9 commits into from
Oct 24, 2022

Conversation

thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented Oct 20, 2022

Related Issue

resolves #21

Screen Shot 2022-10-23 at 7 56 12 PM

Summary of Changes

  1. Integration of features (Upcoming Events, Cast and Crew, and Spotify Playlist)
  2. Added message banner
  3. Minor tweaks and styling

TODO

  1. Local dev SSR index routes not working - SSR index pages are generating the wrong route and not loading correctly in development ProjectEvergreen/greenwood#984
  2. Compose remaining home page content / features and final ordering
    • greeting banner with text + tunesy + events calendar
    • Episodes (YT Playlist)
    • Songs (Spotify Playlist)
    • Cast + Crew
    • Update test cases
  3. Netlify build results in 404 ??? - prerender configuration for SSR pages not generating output HTML ProjectEvergreen/greenwood#986
    Screen Shot 2022-10-20 at 9 36 02 AM
  4. intersection observers for the playlists can just use loading="lazy" - seems like lazy is good enough and will have cross-browser support soon enough, so no JS solution needed!
  5. Run Lighthouse audit

Nice to have

Or just make as new issues

  1. Final Facebook page links should go where? - social media pages and links #55
  2. Upcoming events links should go where? - social media pages and links #55
  3. Lighthouse audit + TODOs - lighthouse audit #56
  4. animation fade-in on below the fold elements (nice to have)
  5. "Tearing" page design (nice to have) - page "tearing" design #53
  6. Styled Scrollbar (nice to have) - styled scrollbar #54
  7. Seeing WCC giving off these warnings, for custom elements imported via HTML - prerender configuration for SSR pages not generating output HTML ProjectEvergreen/greenwood#986
    WARNING: customElement <tt-upcoming-events> is not defined.  You may not have imported it yet.
    WARNING: customElement <tt-cast-crew> is not defined.  You may not have imported it yet.
    WARNING: customElement <tt-spotify-playlist> is not defined.  You may not have imported it yet.

@thescientist13 thescientist13 added the question Further information is requested label Oct 23, 2022
@thescientist13 thescientist13 marked this pull request as ready for review October 23, 2022 23:55
@thescientist13 thescientist13 merged commit 5a46c8a into v1 Oct 24, 2022
@thescientist13 thescientist13 deleted the feature/issue-21-home-page branch October 24, 2022 17:23
thescientist13 added a commit that referenced this pull request Oct 25, 2022
* initial working integration of API events

* upgrade latest greenwood v0.26.1

* initial home page composition

* integrate YouTube playlist component

* upgrade Greenwood v0.26.2

* initial home page composition and sectioning

* greeting message and minor tweaks

* apply first pass of Lighthouse feedback

* update test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Page
1 participant