KmlDataSource uses degrees instead of radians

[ggetz]

In these lines, 90.0 is used instead of Cesium.Math.PI/2.

https://github.com/AnalyticalGraphicsInc/cesium/blob/986ef584156c5ddeaf0ed18c3b33a42aeee66851/Source/DataSources/KmlDataSource.js#L1818

https://github.com/AnalyticalGraphicsInc/cesium/blob/986ef584156c5ddeaf0ed18c3b33a42aeee66851/Source/DataSources/KmlDataSource.js#L1837

Brought up on the forum here: https://groups.google.com/forum/#!topic/cesium-dev/QrwGDAOgt8w

[hpinkos]

@ggetz the first is using fromDegrees so it should be fine. The second should probably be using that as well

[jaforom]

@hpinkos, tilt is converted to radians in line 156361:

tilt = CesiumMath.toRadians(defaultValue(tilt, 0.0));

so 90.0 must be Cesium.Math.PI / 2 in line 156365:

var hpr = new HeadingPitchRange(heading, tilt - 90.0, range);

Regards

[hpinkos]

Thanks @jaforom, you're right! I didn't look at the code very closely.
If you have a minute, we would gladly accept a pull request with this fix

[jaforom]

Sorry, @hpinkos, it would be my first pull request and I don't know how to do it. Could you tell me how to do that?

Regards

[jaforom]

Well, I don't know if it's right, but here it is: #5997

Regards

[cesium-concierge]

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/QrwGDAOgt8w

If this issue affects any of these threads, please post a comment like the following:

The issue at #5992 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

---

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏