KML tours: processing KMLTourFlyTo

[jaforom]

Hi all,

I recorded a tour with Google Earth and then I tried to load it in my Cesium viewer. It went fine, but I noted that the pitch was wrong (the camera was always vertical). In my tour, I used several pitches.

When I found the code where the KMLTourFlyTo is processed, I found this code line, inside processLookAt function:

var hpr = new HeadingPitchRange(heading, tilt - 90.0, range);

This is wrong, because tilt must be in radians, so the correct line code will be:

var hpr = new HeadingPitchRange(heading, tilt - Cesium.Math.PI / 2, range);

The Cesium version is 1.39 and the bug is in line 156365.

I modified the line in CesiumUnminified/Cesium.js and then I loaded the KML again: the tour was right, using the different pitches I recorded in the tour.

Regards

[cesium-concierge]

Welcome to the Cesium community @jaforom!

Can you please send in a Contributor License Agreement (CLA) so that we can review and merge this pull request?

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

---

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

[pjcozzi]

We now have a CLA from @jaforom. Thanks again for the contribution!

[ggetz]

Hi @jaforom, are you should your PR is using the right branch? It looks like you're attempting to merge the cesiumjs.org branch with master. cesiumjs.org should be your branch of Cesium where you made your changes. Checkout the Contributor's Guides if you need more info. Thanks!

[jaforom]

Dear Gabby, You’re right. When I initiate the pull request I did it wrong, because it was my first PR and I didn’t know how to do it correctly. Could you help me about changing the branch to set the right one? I don’t know how to do that. Or may I close it and create a new one by using a fork? Regards

[jaforom]

Maybe I must close this PR and leave #5998 as the right PR.

[ggetz]

@jaforom Yes, it looks like you set up the PR correctly in #5998, thanks! You can go ahead and close this PR.

[jaforom]

The right one is #5998.