-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis Integration #652
Comments
Anyone know how hard this is to do with Travis? @cmorse?
|
It would be possible to have a script runs which checks to see if the |
That is what I was thinking too. I don't know anything about the GitHub API, but I doubt it lets us change the UI. Perhaps we could request it. In the meantime, I wonder if there is another way to notify the developer that opened the pull request, e.g., via email. |
I think the GitHub API allows some changes to the UI. Isn't that how Travis shows the red/yellow/green status on each commit? What about something that adds a comment to every pull request with a reminder to update |
Yeap, that would work nicely. |
@pjcozzi I hacked something together real quick using PyGithub: https://gist.github.com/cmorse/6541012 |
Cool! Let's give it a try. |
How would you like to give it a try? I figured you guys could set it up to post from the AnalyticalGraphicsInc account, or something like that. |
@cmorse this isn't really my area of expertise, but I was hoping that we could trigger this to run once when a pull request is first opened. Is that possible with the GitHub API? It sounds like you suggest running this on a server and polling all the open pull request once in a while. Do you think that's our only option? |
@pjcozzi As far as I can tell, the Github API only supports polling. I would have preferred to do it with a trigger of some kind as well. |
Ugh, I'm not sure that this approach is worth it for us, or at least not worth it yet. |
This could be of interest, for example, to check the GitHub username against a database of users who signed the CLA: https://developer.github.com/v3/repos/statuses/ |
FYI, this is just going to be an automatic part of the build process, and nothing to do with Travis. |
Related to #3571. |
There's been some talk about integrating travis-ci to partially automate merging pull requests. Here's some ideas.
Other ideas:
The text was updated successfully, but these errors were encountered: