Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Travis CI setup #917

Merged
merged 7 commits into from
Jul 1, 2013
Merged

Basic Travis CI setup #917

merged 7 commits into from
Jul 1, 2013

Conversation

cmorse
Copy link
Contributor

@cmorse cmorse commented Jul 1, 2013

I made a basic travis.yml file for #652. The build finishes well within their stated time limit of 50 minutes (or 10 minutes with no log output). I tested it, and it fails when there are syntax errors in the JavaScript, or documentation generation. I wasn't sure how to get documentation generation to generate warnings, so I don't know what will happen with that.

For it to work you have to follow the instructions at: http://about.travis-ci.org/docs/user/getting-started/

You can see the output from travis-ci for this branch here: https://travis-ci.org/cmorse/cesium/builds/8624560

@shunter
Copy link
Contributor

shunter commented Jul 1, 2013

This is great, thanks for getting it working. Can you add jsHint to the ant command line before release, and switch to node 0.10 which should be a bit faster?

@cmorse
Copy link
Contributor Author

cmorse commented Jul 1, 2013

@shunter Ah, I didn't know that the release ant command didn't run jsHint. I changed that.

@cmorse
Copy link
Contributor Author

cmorse commented Jul 1, 2013

I also experimented with getting it to print a message when CHANGES.md has not been updated. Unfortunately, right now Travis doesn't support a warning status for a build, so all I could do was print a message to the console. I just had it run this code:

if ! git diff --name-only $TRAVIS_COMMIT_RANGE | grep -q "CHANGES.md"; then
  echo "WARNING: Did you forget to update CHANGES.md?"
fi

I'll leave it up to you guys if you want to include that check or not.

@shunter
Copy link
Contributor

shunter commented Jul 1, 2013

Yeah, I can't find any way to do warnings, or have it attach comments to pull requests. I'll just merge this as-is, and we can add more checks in the future if we can find a way do to so.

shunter added a commit that referenced this pull request Jul 1, 2013
@shunter shunter merged commit 36d2388 into CesiumGS:master Jul 1, 2013
@cmorse cmorse deleted the travis_ci branch July 1, 2013 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants