More careful splitting of glTF materials #6421
Merged
+39
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug found in #6412 where Polly, the robot dog, lost all her lighting, even emissive lights.
Some materials were used with and without tangents, or with and without morph targets, and needed to be split apart. Also, the
hasTangents
andhasMorphTargets
booleans needed to be isolated to their respective materials (after splitting).