Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More careful splitting of glTF materials #361

Merged
merged 3 commits into from
Apr 4, 2018

Conversation

emackey
Copy link

@emackey emackey commented Apr 3, 2018

This is a copy of CesiumGS/cesium#6421.

emackey added 2 commits April 3, 2018 17:24

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
@coveralls
Copy link

coveralls commented Apr 3, 2018

Coverage Status

Coverage decreased (-0.08%) to 86.213% when pulling 8b7bde0 on emackey:per-material-bools into 25177db on AnalyticalGraphicsInc:2.0-cesium.

@lilleyse
Copy link
Contributor

lilleyse commented Apr 4, 2018

Since there are already no tests in processPbrMetallicRoughness this is good to merge.

@lilleyse lilleyse merged commit 8afa31a into CesiumGS:2.0-cesium Apr 4, 2018
@emackey emackey deleted the per-material-bools branch April 14, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants