-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't swallow server-side exceptions #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🙌
But I think you have to fix the tests. Please check the action logs.
@powellnorma tests are still failing 🤔 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 78.43% 78.51% +0.08%
==========================================
Files 25 25
Lines 612 619 +7
==========================================
+ Hits 480 486 +6
- Misses 132 133 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Thanks again for the PR @powellnorma 🙌 The Codacy is crying for not using assigned variables, but it's fine, I will fix them in my PR. |
#23