Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't swallow server-side exceptions #35

Merged
merged 5 commits into from
Apr 8, 2023

Conversation

powellnorma
Copy link
Contributor

@powellnorma powellnorma commented Apr 7, 2023

#23

Copy link
Owner

@Ananto30 Ananto30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🙌

But I think you have to fix the tests. Please check the action logs.

zero/client_server/client.py Outdated Show resolved Hide resolved
@powellnorma powellnorma requested a review from Ananto30 April 7, 2023 11:36
@Ananto30
Copy link
Owner

Ananto30 commented Apr 7, 2023

@powellnorma tests are still failing 🤔
And please fix the conflict issues 🙏

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.08 🎉

Comparison is base (9577dc0) 78.43% compared to head (56e4b9d) 78.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   78.43%   78.51%   +0.08%     
==========================================
  Files          25       25              
  Lines         612      619       +7     
==========================================
+ Hits          480      486       +6     
- Misses        132      133       +1     
Impacted Files Coverage Δ
zero/client_server/worker.py 24.24% <0.00%> (-0.38%) ⬇️
zero/client_server/client.py 100.00% <100.00%> (ø)
zero/error.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ananto30
Copy link
Owner

Ananto30 commented Apr 8, 2023

Thanks again for the PR @powellnorma 🙌

The Codacy is crying for not using assigned variables, but it's fine, I will fix them in my PR.

@Ananto30 Ananto30 linked an issue Apr 8, 2023 that may be closed by this pull request
@Ananto30 Ananto30 merged commit de463b0 into Ananto30:main Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't swallow Exceptions
2 participants