Use artist and title from UG for the filename #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed so that Android-specific APIs such as `Uri.parse()` can be used in unit tests. These changes were added by following the official documentation: https://robolectric.org/getting-started/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this branch, the app will use the content of Ultimate Guitar's "og:title" meta tag to suggest a better filename. It's a first step for the implementation of #27.
Take a look at the result:
The first two songs have been imported using this branch, whereas the last two items used the
searchTextthat I entered when looking for the songs.The newly added
MetadataExtractionHelpercan be extended to support more pages in the future. The extraction is also covered with unit tests. I needed to add Roboelectric to be able to useUriin the unit test.