[#163818577] Handle edges cases on file import error #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthur236
approved these changes
Feb 12, 2019
houndci-bot
reviewed
Feb 21, 2019
Arthur236
force-pushed
the
ft-handle-edge-cases-on-file-import-163818577
branch
from
0abbc13
to
8b853d0
Compare
fojuri
force-pushed
the
ft-handle-edge-cases-on-file-import-163818577
branch
from
8b853d0
to
a25c561
Compare
- update branch with changes from develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It enables an admin user to see an appropriate error when the user upload a file with a wrong format.
Description of Task to be completed?
The right error message should be sent to the user when uploading a file with a wrong file format.
How should this be manually tested?
In the upload section, click to upload or drag and drop a faulty file, a message is seen indicating the exact issue with the file.
What are the relevant pivotal tracker stories?
#163818577
Any background context you want to add?
N/A
Important notes
N/A
Packages installed
N/A
Deployment note
N/A
Related PRs branch | PR (branch_name) | (pr_link)
Todos
Screenshots