#165053196 admin is able to view department details. #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbols
force-pushed
the
ft-department-assets-165053196
branch
from
0da71c2
to
337cebb
Compare
fojuri
requested changes
Jun 25, 2019
| @@ -19,7 +19,7 @@ export class DepartmentDetailComponent extends React.Component { | |||
|
|
|||
|
|
|||
| assetsAssigned = (assets) => { | |||
| if (isEmpty(assets.assets_assigned)) { | |||
| if (isEmpty(assets.assets_assigned.result)) { | |||
There was a problem hiding this comment.
This should be assets.assets_assigned.results
gbols
force-pushed
the
ft-department-assets-165053196
branch
from
337cebb
to
08ce4ea
Compare
fojuri
reviewed
Jun 26, 2019
| @@ -15,11 +15,11 @@ export class DepartmentDetailComponent extends React.Component { | |||
| } | |||
|
|
|||
| getAssignedAssets = assets => | |||
| this.props.getAssetsSuccess({ results: assets.assets_assigned, count: assets.assets_assigned.length }, ''); | |||
| this.props.getAssetsSuccess({ results: assets.assets_assigned.results, count: assets.assets_assigned.results.length }, ''); | |||
There was a problem hiding this comment.
Suggested change
| this.props.getAssetsSuccess({ results: assets.assets_assigned.results, count: assets.assets_assigned.results.length }, ''); | |
| this.props.getAssetsSuccess({ results: assets.assets_assigned.results, count: assets.assets_assigned.count }, ''); |
| </Header> | ||
| <Header> | ||
| Total Assets Assigned: {details.assets_assigned.length} | ||
| Total Assets Assigned: {assets_assigned.results.length} |
There was a problem hiding this comment.
Suggested change
| Total Assets Assigned: {assets_assigned.results.length} | |
| Total Assets Assigned: {assets_assigned.count} |
gbols
force-pushed
the
ft-department-assets-165053196
branch
from
08ce4ea
to
bbd4a9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
View Assets assigned to a department.
Description of Task to be completed?
Allow Admin to view departments details or appropriate message.
How should this be manually tested?
Login with an admin email(The properties of this user should read as folllows: admin: true, superuser: false)
Visit
Home -> DepartmentsWhat are the relevant pivotal tracker stories?
#165053196
Any background context you want to add?
N/A
Important notes
N/A
Packages installed
N/A
Deployment note
Related PRs branch | PR (branch_name) | (pr_link)
Todos
Screenshots