Switch from serde_test
to serde_assert
.
#163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #162.
I'm really happy with the improvements with this one. The biggest improvement was the significantly reduced complexity of the
Allocator
andArchetypes
tests, both of which are testingDeserializeSeed
implementations. Before, a complicatedDeserialize
-able newtype wrapper was required, but now we can just use the type directly. For theAllocator
case, this eliminated hundreds of lines of code.Additionally, the code now tests the full round-trip serialize and deserialize into sequences, which was not possible with
serde_test
.And finally, #160 should be unblocked, due to
serde_assert
'sUnordered
, which will allow the tests to still be possible when token order is no longer guaranteed.