Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clippy in continuous integration workflow #44

Merged
merged 15 commits into from
Feb 11, 2022
Merged

Run clippy in continuous integration workflow #44

merged 15 commits into from
Feb 11, 2022

Conversation

Anders429
Copy link
Owner

Fixes some clippy lints and enables clippy in CI. This is the last step of #9.

@Anders429 Anders429 linked an issue Feb 6, 2022 that may be closed by this pull request
11 tasks
@Anders429
Copy link
Owner Author

Looks like this is failing because clippy is being run on stable, while I tested locally on nightly. This is because associated types were recently ignored in this lint (see this PR), but that change doesn't seem to have bubbled up into stable yet. I'll go ahead and switch the workflow to run on nightly instead.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022

Codecov Report

Merging #44 (a80d1e6) into master (848dc68) will decrease coverage by 0.17%.
The diff coverage is 10.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   19.28%   19.10%   -0.18%     
==========================================
  Files          50       50              
  Lines        3672     3664       -8     
==========================================
- Hits          708      700       -8     
  Misses       2964     2964              
Impacted Files Coverage Δ
src/archetype/identifier/iter.rs 100.00% <ø> (ø)
src/archetype/identifier/mod.rs 91.00% <ø> (ø)
src/archetype/mod.rs 14.74% <ø> (ø)
src/entity/allocator/mod.rs 0.00% <0.00%> (ø)
src/registry/debug.rs 0.00% <0.00%> (ø)
src/registry/eq.rs 0.00% <0.00%> (ø)
src/registry/serde.rs 0.00% <0.00%> (ø)
src/system/schedule/sendable.rs 0.00% <0.00%> (ø)
src/system/schedule/stage/seal.rs 0.00% <0.00%> (ø)
src/system/schedule/task.rs 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848dc68...a80d1e6. Read the comment docs.

@Anders429
Copy link
Owner Author

Anders429 commented Feb 6, 2022

Two of the three failures are related to a regression on the latest nightly builds of clippy. See this issue. I believe the third is also a false-positive, as Option<T> implements Copy if T implements Copy, and Location is Copy. Therefore, removing the reference is actually not the same thing logically. Here is a related issue.

Perhaps I should stick to stable instead? Or at least the beta channel? It seems that nightly may be a little more unstable than I hoped for.

Edit: looks like beta has its own can of worms. Perhaps clippy may have to wait? Not sure what else to do here.

@Anders429
Copy link
Owner Author

I'm going to keep this workflow running on nightly. It looks like these lints will be fixed and live on nightly soon. This merge can wait until then.

@Anders429
Copy link
Owner Author

Rather than waiting, I will put an allow lint for these, with a todo comment referencing the relevant issues. That will unblock this.

@Anders429 Anders429 merged commit ae44570 into master Feb 11, 2022
@Anders429 Anders429 deleted the clippy branch February 11, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up continuous integration
2 participants