Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade prompt dep to fix non-existent property warning #92

Conversation

jamsinclair
Copy link

@jamsinclair jamsinclair commented May 16, 2022

Summary

Fixes #74

When running the command line tool with node versions greater than 14, the following warning is displayed:

(node:1793) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency

With node --trace-warnings enabled we see the full warning:

(node:1793) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
    at emitCircularRequireWarning (node:internal/modules/cjs/loader:707:11)
    at Object.get (node:internal/modules/cjs/loader:721:5)
    at Object.exports.setLevels (/Users/person/workspace/NodeMCU-Tool/node_modules/winston/lib/winston/common.js:32:14)
    at Object.<anonymous> (/Users/person/workspace/NodeMCU-Tool/node_modules/winston/lib/winston.js:83:8)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)

This seems to relate to an old version winston used by the prompt library. Upgrading prompt to 1.x.x seems to resolve the issue and the command line works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annoying warning for every command with nodemcu-tool
2 participants