Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Router Controller Support #6

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Multi Router Controller Support #6

wants to merge 26 commits into from

Conversation

AndiLavera
Copy link
Owner

No description provided.

@AndiLavera
Working on single api for multiple routers
aff97b9
@AndiLavera
Multi-framework support for controllers
044aec3
@AndiLavera
Rename user controller macros
068560d
@AndiLavera
Minor Gitbook Update
a646258
@AndiLavera
ER => Handler (Renderer => Renderhandler), Jasper extension, Session …
d430886 
…controller using contract
@AndiLavera
Fastforward from master
96867fc
@AndiLavera
User Controller test
578cea1
@AndiLavera
Merge branch 'master' of github.com:gitlato/mochi into multi-api
b6b7184
@AndiLavera
Converting controllers over to new contract system
074a472
@AndiLavera
Finished converting controllers, converted cli template controllers t…
3af410c 
…o new system
@AndiLavera
General Fixes
8a14551
@AndiLavera
Modules & macros
1f3d0ba
@AndiLavera
Merge branch 'master' of github.com:gitlato/mochi into multi-api-macro
42af6a0
@AndiLavera
Fixed regression due to merge
4f15373
@AndiLavera
Moved user_controller_spec
fc251ca
@AndiLavera
Converted contract methods to macros + Removed unncessary files
b007026
@AndiLavera
Email regex
35fb9eb
@AndiLavera
Better validations
11bef19
@AndiLavera
Tests + changing over to new contract system
fe0cf34
@AndiLavera
All controllers are using new contract system
3e3a389
@AndiLavera
ORM queries belong in controller macros
08d0f51
@AndiLavera
Amber spec controllers done
f2f2cc1
@AndiLavera
Controller specs are built
8f740ac
@AndiLavera
Unlock controller tests
61c9a7b
@AndiLavera
3 controller tests testing every exit
d2a9c5b
@AndiLavera
Crystal 0.34.0 Update
bc64911
@AndiLavera
Copy link
Owner Author

I really don't know how i feel about multi framework support right now. This PR is definitely being closed. I ported over some updates & specs from this PR into the master branch. What really remains the controllers.

I created an api which can be found in src/mochi/helpers/. The only 100% completed one is Amber but i did test the idea with athena & lucky with a proof-of-concept that looks like it worked.

My issue is it added so many new files & logic not related to authencation. Currently, i feel like I would spend more time fixing bugs related to controller logic rather than authentication logic.

This will sit open while i decide what do with multi router support.

@alexanderadam
Copy link

Would it make sense to split it up instead into a mochi_common shard and mochi_amber, mochi_lucky, …?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndiLavera @alexanderadam