Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oven support #14

Merged
merged 4 commits into from
Apr 8, 2023
Merged

Add oven support #14

merged 4 commits into from
Apr 8, 2023

Conversation

MiguelAngelLV
Copy link
Contributor

Add oven (OV) category support.

It works fine with my oven model is a Haier HWO60SM2F3XH.

The one "problem" is the huge options of programs, because show the standar programs, the special programs and the recipe list.

I think that Selects should be a parameter for filter some options that contains a string ("recipe" in my case).

@Andre0512
Copy link
Owner

Hey, awesome! Thank you for adding this! 😃

I have thought about this "problem" and I think a clean solution here is to solve it via the pyhOn library. I have implemented this as I thought it could be work in v0.5.0, you should be able now to create a Select with the key program_filter. Can you test this and maybe create a pr here?
I'm not sure if I understood it correctly, is it right to filter it by it's program name? Feel free to correct my code in the pyhOn library 🙂

@Andre0512 Andre0512 merged commit c78aeb1 into Andre0512:main Apr 8, 2023
Andre0512 added a commit that referenced this pull request Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants