You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The way the balance toolbar gets updated is currently buggy and requires a refactoring.
Balance needs to be fetched and cached when:
account address changed
Overview toolbar title needs to show balance when:
Overview MDBottomNavigationItem is shown (from the OverviewScreen.OverviewBottomNavigation)
This usually happens when the "Overview" is explicitly clicked or when coming back from another screen e.g. account selection. The problem is when coming back from account selection, only the parent screen OverviewScreen gets its on_pre_enter event fired. So the sub-screen doesn't know it's being shown and can't update the Toolbar title. Also another issue is that we cannot systematically load the Toolbar title with balance on OverviewScreen.on_pre_enter since this can also be fired from the "Send" or "Receive" sub-screens. So we need to find a way to know which sub-screen is being loaded.
The last annoying thing is that balance update is done asynchronously, so we need to bind the title to be updated on balance update, but only when the overview subscreen is selected...
The text was updated successfully, but these errors were encountered:
The way the balance toolbar gets updated is currently buggy and requires a refactoring.
Balance needs to be fetched and cached when:
Overview toolbar title needs to show balance when:
MDBottomNavigationItem
is shown (from theOverviewScreen.OverviewBottomNavigation
)This usually happens when the "Overview" is explicitly clicked or when coming back from another screen e.g. account selection. The problem is when coming back from account selection, only the parent screen
OverviewScreen
gets itson_pre_enter
event fired. So the sub-screen doesn't know it's being shown and can't update the Toolbar title. Also another issue is that we cannot systematically load the Toolbar title with balance onOverviewScreen.on_pre_enter
since this can also be fired from the "Send" or "Receive" sub-screens. So we need to find a way to know which sub-screen is being loaded.The last annoying thing is that balance update is done asynchronously, so we need to bind the title to be updated on balance update, but only when the overview subscreen is selected...
The text was updated successfully, but these errors were encountered: