Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 error in new install #150

Closed
YPCrumble opened this issue Jul 2, 2024 · 2 comments · Fixed by #151 or #152
Closed

404 error in new install #150

YPCrumble opened this issue Jul 2, 2024 · 2 comments · Fixed by #151 or #152
Assignees
Labels
bug Something isn't working

Comments

@YPCrumble
Copy link

Thanks for creating this great package! I'm trying to migrate from xo and found your repo here.

I'm getting this error on npx create-sheriff-config:

Need to install the following packages:
create-sheriff-config@5.1.2
Ok to proceed? (y) y
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@sherifforg%2fconstants - Not found
npm ERR! 404
npm ERR! 404  '@sherifforg/constants@0.0.1' is not in this registry.
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.
@AndreaPontrandolfo
Copy link
Owner

Hey @YPCrumble thank you!

I think npm is trying to install @sherifforg/constants, which is a private package that Sheriff uses internally. It doesn't exists in NPM and rightly so.
But im not sure to understand why npm is trying to install it.
Will dig deeper on this.

@AndreaPontrandolfo AndreaPontrandolfo self-assigned this Jul 2, 2024
@AndreaPontrandolfo AndreaPontrandolfo added the bug Something isn't working label Jul 2, 2024
AndreaPontrandolfo added a commit that referenced this issue Jul 7, 2024
…sue150

fix(deps): moved @sherifforg/constants to devDeps. Fixes #150
@AndreaPontrandolfo
Copy link
Owner

Hey @YPCrumble,

So, it was a bundling issue, TSUP wasn't bundling @sherifforg/constants inside the other libs.

It's all good now, i'm gonna release the new version with this fix just now. Thank you so much for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants