Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: .templatesyncignore not handling comments #536

Closed
1 task done
AndreasAugustin opened this issue Jun 15, 2024 · 0 comments · Fixed by #538
Closed
1 task done

[Bug]: .templatesyncignore not handling comments #536

AndreasAugustin opened this issue Jun 15, 2024 · 0 comments · Fixed by #538
Assignees
@AndreasAugustin
Labels
bug Something isn't working

Comments

@AndreasAugustin
Copy link
Owner

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

The .templatesyncignore is not handling comments.
Example ICESAT-2HackWeek/IS2-website-2024#2

The issue came with #512 or was even present before.

Expected Behavior

The .templatesyncignore should handle comments

Current Behavior

current behaviour:

☁  IS2-website-2024 [tmp] ⚡  cat .templatesyncignore | awk NF | xargs echo           
# THIS FILE CANNOT BE SYNCED # use glob patterns as in .gitignore # recommend listing non-basics tutorial directories here # configuration files cookiecutter.yaml # environment lock files conda/*lock.yml # team member files team/*-* # book files (configuration, usage-specific) book/_config.yml # event-specific tutorials

Steps To Reproduce

No response

Possible Solution

No response

Additional Information/Context

☁  IS2-website-2024 [tmp] ⚡  cat .templatesyncignore | awk NF | xargs echo           
# THIS FILE CANNOT BE SYNCED # use glob patterns as in .gitignore # recommend listing non-basics tutorial directories here # configuration files cookiecutter.yaml # environment lock files conda/*lock.yml # team member files team/*-* # book files (configuration, usage-specific) book/_config.yml # event-specific tutorials

Template sync version Version

v2.2.1
@AndreasAugustin AndreasAugustin added the bug Something isn't working label Jun 15, 2024
@AndreasAugustin AndreasAugustin mentioned this issue Jun 15, 2024
Closed
AndreasAugustin added a commit that referenced this issue Jun 16, 2024
@AndreasAugustin
fix(#536): 🐛 issue with comments within .templatesyncignore
9f7681e 
Signed-off-by: Andy Augustin <dev@andreas-augustin.org>
@AndreasAugustin AndreasAugustin mentioned this issue Jun 16, 2024
Merged
@AndreasAugustin AndreasAugustin self-assigned this Jun 16, 2024
@AndreasAugustin AndreasAugustin moved this from To do to Review in progress in actions-template-sync Jun 16, 2024
AndreasAugustin added a commit that referenced this issue Jun 19, 2024
@AndreasAugustin
fix(#536): 🐛 issue with comments within .templatesyncignore (#538)
aba0971 
Signed-off-by: Andy Augustin <dev@andreas-augustin.org>
@github-project-automation github-project-automation bot moved this from Review in progress to Done in actions-template-sync Jun 19, 2024
@github-actions github-actions bot mentioned this issue Jun 19, 2024
Merged
@github-actions github-actions bot mentioned this issue Oct 10, 2024
Merged
@github-actions github-actions bot mentioned this issue Oct 29, 2024
Merged
@github-actions github-actions bot mentioned this issue Dec 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreasAugustin AndreasAugustin

Labels
bug Something isn't working
Projects
actions-template-sync
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#536): 🐛 issue with comments within .templatesyncignore AndreasAugustin/actions-template-sync
1 participant
@AndreasAugustin