Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bugfixes & features #49

Closed

Conversation

cspotcode
Copy link
Contributor

@cspotcode cspotcode commented Oct 27, 2018

Splitting #40 into multiple PRs for easier review.

@cspotcode cspotcode changed the title Small bugfixes features Small bugfixes & features Oct 27, 2018
@AndreasMadsen
Copy link
Owner

I don't know what this fixes. To me, it adds two unrelated features.

I'm okay with the "async boundary" line, it has been requested a few times, but it has to be implemented properly to ensure compatibility with other modules. See for example AndreasMadsen/stack-chain#7

I'm closing this for now. If you feel like implementing AndreasMadsen/stack-chain#7, then we can reopen this.

@cspotcode
Copy link
Contributor Author

The two other changes are also from #40:

  • adding a disable() method to stop tracing, opposite of enable()
  • Fixing the logic that excludes async_hooks.js stack frames.

For the latter, it looks like this library intends to remove all "async_hooks.js" stack frames from traces. In node v11, there's an "internal/async_hooks.js", so if you want to filter out those frames, an additional equality check is required.

They're both tiny, so if anyone wants to get them merged, it should be easy to cherry-pick into separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants