Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial conversion of MD hyperlinks to MediaWiki #9

Closed
wants to merge 1 commit into from

Conversation

Andrew-Chen-Wang
Copy link
Owner

Description

Automatic conversion of hyperlinks to MediaWiki format

Rationale

Fixes #8

@Andrew-Chen-Wang Andrew-Chen-Wang added the enhancement New feature or request label Dec 18, 2021
@jcbhmr
Copy link
Collaborator

jcbhmr commented Mar 10, 2023

I don't know if this should be in scope for this action? Is this GitHub action positioned as:

  1. Your single-action one-stop-shop to deploy a folder to github wiki (handles build actions, possible rewriting, asset collection, etc.)
  2. OR Just push a folder in git to a GitHub wiki

It's worth noting that this action is OK being a single-thing unix philosophy action!

- uses: Andrew-Chen-Wang/rewrite-markdown-links
  with:
    path: wiki
- run: git add -A && git commit --amend --no-edit
- uses: Andrew-Chen-Wang/github-wiki-action

This is kinda inline with what seems to be the convention of the official https://github.com/actions how they do things, and would be more modular overall

However this happens to pan out, I'd recommend updating the readme, the wiki, or somewhere with something like "Goals" or "Scope" to define what you want the boundary to be so that if I ask "hey can I get this action to support compiling React apps to Markdown for my wiki?" you can point and say "no look for another action to preprocess" or "sure! that sounds like a good feature!"

@jcbhmr jcbhmr mentioned this pull request Mar 10, 2023
@Andrew-Chen-Wang
Copy link
Owner Author

Andrew-Chen-Wang commented Mar 10, 2023

Yea I agree, splitting out would be nice, possibly with a github org instead of personal repo.

@jcbhmr jcbhmr marked this pull request as draft March 23, 2023 19:23
@jcbhmr jcbhmr mentioned this pull request May 16, 2023
12 tasks
@jcbhmr
Copy link
Collaborator

jcbhmr commented May 16, 2023

discussed in #8 (comment)

gist is that I think we should do something like:

image

@jcbhmr
Copy link
Collaborator

jcbhmr commented May 17, 2023

I think this is "solved" with the addition of https://github.com/Andrew-Chen-Wang/github-wiki-action#preprocessing note? Closing... Feel free to reopen if you want to continue to pursue this! ❤️

@jcbhmr jcbhmr closed this May 17, 2023
@jcbhmr jcbhmr deleted the mediawiki branch June 9, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically transform in-source links to in-wiki links
2 participants