Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The package '@dongminyu/react-native-step-counter' doesn't seem to be linked #29

Closed
bundittha opened this issue Aug 19, 2023 · 15 comments
Closed
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@bundittha
Copy link

React Native Step Counter New Issue

System:
OS: macOS 13.4
CPU: (10) arm64 Apple M2 Pro
Memory: 90.77 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 16.19.1
path: /var/folders/9b/n0rg4df53tl1jtslh236tfmm0000gn/T/yarn--1692443137067-0.6712097544769973/node
Yarn:
version: 1.22.19
path: /var/folders/9b/n0rg4df53tl1jtslh236tfmm0000gn/T/yarn--1692443137067-0.6712097544769973/yarn
npm:
version: 8.19.3
path: ~/.nvm/versions/node/v16.19.1/bin/npm
Watchman:
version: 2023.04.10.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.12.1
path: /Users/buddy/.rvm/gems/ruby-3.0.0/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.4
- iOS 16.4
- macOS 13.3
- tvOS 16.4
- watchOS 9.4
Android SDK:
API Levels:
- "29"
- "30"
- "31"
- "32"
- "33"
- "33"
Build Tools:
- 29.0.3
- 30.0.2
- 30.0.3
- 31.0.0
- 33.0.0
- 33.0.2
System Images:
- android-29 | Google APIs ARM 64 v8a
- android-31 | Google Play ARM 64 v8a
- android-33 | Google APIs ARM 64 v8a
- android-33 | Google Play ARM 64 v8a
Android NDK: 22.1.7171670
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9514443
Xcode:
version: 14.3.1/14E300c
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.18
path: /usr/bin/javac
Ruby:
version: 3.0.0
path: /Users/buddy/.rvm/rubies/ruby-3.0.0/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.4
wanted: 0.72.4
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false

Expected Behavior

  • I am trying to build with this library.

Actual Behavior

  • I am getting the following error only on Android when newArchEnabled = false
  • On Android newArchEnabled = true it work normally

Screenshot_20230819_181029

  • I think it relate to this line. I have log NativeModule.RNStepCounter is null
Screenshot 2566-08-19 at 18 12 51

Specifications

  • @dongminyu/react-native-step-counter version: 0.1.14
@bundittha
Copy link
Author

bundittha commented Aug 24, 2023

Screenshot 2566-08-25 at 00 36 16

I think this is root cause, I can fixed by patch-package. Thank you for your times @AndrewDongminYoo

@zvici
Copy link

zvici commented Aug 29, 2023

image

"@dongminyu/react-native-step-counter": "^0.2.1"
"react-native": "0.70.6"

in gradle.properties
newArchEnabled=false

I also have the same problem

@fzerman
Copy link

fzerman commented Sep 5, 2023

I have same error with 0.2.1 on react-native 0.71.11 without newArch

@AndrewDongminYoo
Copy link
Owner

Well 🧐🧐🧐 I apologize for the delayed update on the issue. It looks like the syntax for NativeModules.RNStepCounter should be changed to NativeModules.StepCounter, as you're pointing out. I'll try to get that into the code as soon as possible. Please use tools like patch-packages to prioritize this. Thanks for being patient.

@mauriciolcs
Copy link
Contributor

mauriciolcs commented Oct 3, 2023

same problem here, it looks like the package is not linking correctly on android
ios is working fine

@mehandi-bytes
Copy link

mehandi-bytes commented Oct 18, 2023

same problem here, it looks like the package is not linking please help me out
@morricedev do you find any solution

@mauriciolcs
Copy link
Contributor

@mehandi-bytes

Which release are you trying? The v0.2.2 is working for me.

@mehandi-bytes
Copy link

mehandi-bytes commented Oct 18, 2023

0.2.3

can you please provide me a step for installation

@bundittha
Copy link
Author

0.2.3

can you please provide me a step for installation

If you facing same problem with me I think problem is this class

Screenshot 2566-10-18 at 17 38 56

you can extend with this class ReactContextBaseJavaModule(context)
Hope it can help

@mehandi-bytes
Copy link

mehandi-bytes commented Oct 18, 2023

@bundittha @morricedev need help

image

so i can write down but still not working

image

i can change this file

@mehandi-bytes
Copy link

mehandi-bytes commented Oct 18, 2023

@morricedev @bundittha help o

instead i got this error

image

@bundittha
Copy link
Author

instead i got this error

image
My solution will work only in old architecture I see you turn on new architecture. I did't face issue on new architect

@mauriciolcs
Copy link
Contributor

@mehandi-bytes Could you downgrade to 0.2.2 version and try again?

It may be that some change in this new version is causing this error

@mehandi-bytes
Copy link

@mehandi-bytes Could you downgrade to 0.2.2 version and try again?

It may be that some change in this new version is causing this error

i have done it to low version as a result not working

@mauriciolcs
Copy link
Contributor

@mehandi-bytes Could you downgrade to 0.2.2 version and try again?
It may be that some change in this new version is causing this error

i have done it to low version as a result not working

I recommend you open a new issue with more details, so I can help you better there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Development

No branches or pull requests

6 participants