Bring fork up to date #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes an update to mem to resolve a potential DoS vulnerability in command-line processing. The vulnerable version of mem is still included by development dependencies. Fixes #918
* Fix missing command temp-directory After changing tempDirectory to tempDir, with a fallback for tempDirectory, the default values set in the 'temp-dir' yargs option were being used rather than falling back to tempDirectory and then the default temp dir. This change removes the yargs default value for the option 'temp-dir'. This means the statement that assigns '_tempDirectory' in 'index.js' attempts to use temp-dir, then temp-directory, then the default value. This is now under test with some new test cases that show: - tempDir is preferred to tempDirectory - tempDirectory is used if tempDir isn't set - that we fall back to the '.nyc_output' dir if neither tempDir or tempDirectory are set. * Alternate implementation Maintains notice of default temp-dir in help output. Removed tests as I'm not confident with these right now, will take another look when I get some time. Fixes #927.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.