✨ end function, noWinnerMessage option #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Androz2091
reviewed
Aug 29, 2021
Androz2091
reviewed
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So some people want to send a message in the channel if there is no valid winner in the normal ending.
And ik and told people that i can be done with the event but since reroll also has the messages option and technically smth fast enough could come before the event I think it's alright to add this.
But so what confuses me is the original description of
giveaway.messages.noWinner=Sent in the channel if there is no valid winner for the giveaway.since it suggest that it should have gotten sent in the channel, but i searched back and this message and description were added in v.3.0.0 but there never was code that sent it in the channel. Even before v.3.0.0 nothing got sent in the channel, so was idk was this just forgotten? Or was it never planned to be sent and the description just ended up like that because of stress?Anyway since up until now no one complaint, I just changed the description of
noWinnerand made a separate option (noWinnerMessage) only for the end function which per default is null, so no one gets surprised.But if someone (looking at androz) can explain the mystery of
giveaway.messages.noWinner's description, then that would be nice.