Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typings for typescript support #56

Merged
merged 8 commits into from
May 27, 2020
Merged

Add typings for typescript support #56

merged 8 commits into from
May 27, 2020

Conversation

Hazmi35
Copy link
Contributor

@Hazmi35 Hazmi35 commented May 27, 2020

Fixes #55

Androz2091
Androz2091 requested changes May 27, 2020
View reviewed changes
Copy link
Owner

@Androz2091 Androz2091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR thank you 👍
Also, I wasn't able to test it on my computer, I'm getting discord-giveaways/typings/index.d.ts is not a module. Do you know why?

typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
Hazmi35 and others added 2 commits May 27, 2020 14:21
@Hazmi35 @Androz2091
Update typings/index.d.ts
671e913 
Co-authored-by: Androz <androz2091@gmail.com>
@Hazmi35 @Androz2091
Update typings/index.d.ts
5f7f28f 
Co-authored-by: Androz <androz2091@gmail.com>
@Hazmi35
Copy link
Contributor Author

Hazmi35 commented May 27, 2020

Also, I wasn't able to test it on my computer, I'm getting discord-giveaways/typings/index.d.ts is not a module. Do you know why?

I don't get discord-giveaways/typings/index.d.ts is not a module. can you explain a little more?

Hazmi35 and others added 3 commits May 27, 2020 14:25
@Hazmi35 @Androz2091
Update typings/index.d.ts
73a1928 
Co-authored-by: Androz <androz2091@gmail.com>
@Hazmi35 @Androz2091
Update typings/index.d.ts
c9c0921 
Co-authored-by: Androz <androz2091@gmail.com>
@Hazmi35 @Androz2091
Update typings/index.d.ts
8609d54 
Co-authored-by: Androz <androz2091@gmail.com>
Androz2091
Androz2091 approved these changes May 27, 2020
View reviewed changes
Copy link
Owner

@Androz2091 Androz2091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay, I finally got it to work. Thank you for your contribution 👍

@Androz2091 Androz2091 merged commit fcdffe9 into Androz2091:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Androz2091 Androz2091 Androz2091 approved these changes

@satoufuyuki satoufuyuki satoufuyuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript Support
3 participants
@Hazmi35 @Androz2091 @satoufuyuki