Skip to content

[Contributing Rule Change] 贡献指南规范化 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 20, 2022
Merged

[Contributing Rule Change] 贡献指南规范化 #104

merged 6 commits into from
Feb 20, 2022

Conversation

recolic
Copy link
Collaborator

@recolic recolic commented Feb 19, 2022

No description provided.

@recolic recolic requested a review from Anduin2017 February 19, 2022 10:02
recolic
recolic commented Feb 19, 2022
View reviewed changes
@recolic recolic changed the title [Contributing Rule Change] Enhance contributing guide [Contributing Rule Change] 贡献指南规范化 Feb 19, 2022
recolic
recolic commented Feb 19, 2022
View reviewed changes
@recolic recolic added the open discussion Discussion for long-term enhancement label Feb 19, 2022
Anduin2017
Anduin2017 requested changes Feb 19, 2022
View reviewed changes
Copy link
Owner

@Anduin2017 Anduin2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实我是觉得描述太多的话，其它人无法快速上手或把已有菜谱快速修改并签入。建议删掉一些无意义的感想，仅保留最简明的要求

@Anduin2017
Copy link
Owner

Anduin2017 commented Feb 19, 2022 •
edited
Loading

Close。因为已经使用模板。

PR里的文字内容将移植到模板中。

https://raw.githubusercontent.com/Anduin2017/HowToCook/master/dishes/template/%E7%A4%BA%E4%BE%8B%E8%8F%9C/%E7%A4%BA%E4%BE%8B%E8%8F%9C.md

@Anduin2017 Anduin2017 closed this Feb 19, 2022
@recolic
Copy link
Collaborator Author

recolic commented Feb 20, 2022

这个PR刚开始是为贡献者和维护者设计的, 简明易懂的模板确实满足了贡献者的需求.

但我修改了这个指南, 使它仍然为维护者服务. 我主观认为有必要以正式而严谨的语言, 来保留仓库的principle.
please review it again)

@recolic recolic reopened this Feb 20, 2022
@recolic recolic requested a review from Anduin2017 February 20, 2022 09:19
@Anduin2017 Anduin2017 merged commit 2acc19a into Anduin2017:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobby285271 bobby285271 bobby285271 left review comments

@Anduin2017 Anduin2017 Anduin2017 approved these changes

Assignees

@Anduin2017 Anduin2017

Labels
open discussion Discussion for long-term enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@recolic @Anduin2017 @bobby285271