fixes mapbox#1675: abstract annotation tile refresh check/render; tri…

…gger post-sprite/sprite store load
AndwareSsj · Sep 11, 2015 · 00ca1f7 · 00ca1f7
1 parent f201aed
commit 00ca1f7
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 2 deletions.
diff --git a/src/mbgl/map/annotation.hpp b/src/mbgl/map/annotation.hpp
@@ -52,6 +52,7 @@ class AnnotationManager : private util::noncopyable {
     ~AnnotationManager();
 
     void markStaleTiles(std::unordered_set<TileID, TileID::Hash>);
+    size_t getStaleTileCount() const { return staleTiles.size(); }
     std::unordered_set<TileID, TileID::Hash> resetStaleTiles();
 
     void setDefaultPointAnnotationSymbol(const std::string& symbol);

diff --git a/src/mbgl/map/map_context.cpp b/src/mbgl/map/map_context.cpp
@@ -142,9 +142,11 @@ void MapContext::loadStyleJSON(const std::string& json, const std::string& base)
 
     updateFlags |= Update::DefaultTransition | Update::Classes | Update::Zoom;
     asyncUpdate->send();
+}
 
-    auto staleTiles = data.getAnnotationManager()->resetStaleTiles();
-    if (!staleTiles.empty()) {
+void MapContext::updateAnnotationTilesIfNeeded() {
+    if (data.getAnnotationManager()->getStaleTileCount()) {
+        auto staleTiles = data.getAnnotationManager()->resetStaleTiles();
         updateAnnotationTiles(staleTiles);
     }
 }
@@ -417,4 +419,8 @@ void MapContext::onResourceLoadingFailed(std::exception_ptr error) {
     }
 }
 
+void MapContext::onSpriteStoreLoaded() {
+    updateAnnotationTilesIfNeeded();
+}
+
 }
diff --git a/src/mbgl/map/map_context.hpp b/src/mbgl/map/map_context.hpp
@@ -54,6 +54,7 @@ class MapContext : public Style::Observer {
     bool isLoaded() const;
 
     double getTopOffsetPixelsForAnnotationSymbol(const std::string& symbol);
+    void updateAnnotationTilesIfNeeded();
     void updateAnnotationTiles(const std::unordered_set<TileID, TileID::Hash>&);
 
     void setSourceTileCacheSize(size_t size);
@@ -66,6 +67,7 @@ class MapContext : public Style::Observer {
     // Style::Observer implementation.
     void onTileDataChanged() override;
     void onResourceLoadingFailed(std::exception_ptr error) override;
+    void onSpriteStoreLoaded() override;
 
 private:
     // Update the state indicated by the accumulated Update flags, then render.

diff --git a/src/mbgl/style/style.cpp b/src/mbgl/style/style.cpp
@@ -190,6 +190,10 @@ void Style::onSpriteLoaded(const Sprites& sprites) {
     // Add all sprite images to the SpriteStore object
     spriteStore->setSprites(sprites);
 
+    if (observer) {
+        observer->onSpriteStoreLoaded();
+    }
+
     shouldReparsePartialTiles = true;
     emitTileDataChanged();
 }

diff --git a/src/mbgl/style/style.hpp b/src/mbgl/style/style.hpp
@@ -39,6 +39,7 @@ class Style : public GlyphStore::Observer,
         virtual ~Observer() = default;
 
         virtual void onTileDataChanged() = 0;
+        virtual void onSpriteStoreLoaded() = 0;
         virtual void onResourceLoadingFailed(std::exception_ptr error) = 0;
     };
 

diff --git a/test/style/resource_loading.cpp b/test/style/resource_loading.cpp
@@ -63,6 +63,10 @@ class MockMapContext : public Style::Observer {
         callback_(error);
     }
 
+    void onSpriteStoreLoaded() override {
+        // no-op
+    }
+
 private:
     MapData data_;
     Transform transform_;