Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Remove line-height from body #51

Open
benoitchantre opened this issue Aug 31, 2021 · 1 comment
Open

Remove line-height from body #51

benoitchantre opened this issue Aug 31, 2021 · 1 comment

Comments

@benoitchantre
Copy link

The line-height property with a value of 1.5 is a good default value, but maybe something opiniated that could be removed, because it will certainly be adjusted according to the design needs.

Another reason is that WordPress (and maybe other tools) allows us to generate some styles from a json file. As these base styles are declared before any other stylesheet, we can't use the generated value for line-height because it will be loaded too early and overloaded.

Would you accept a PR to remove that property?

@julianjohannesen
Copy link

I think the line-height of at least 1.5 is designed to meet accessibility standards, especially in the context of blocks of text where the font-size is fairly small. Sure, it's opinionated, but at the same time, it's something that designers really aught to embrace, especially at small font-sizes.

Obviously, line-height: 1.5 isn't going to work for headings, which is why some people are suggesting using line-height: calc(1em + .5rem). This setting satisfies the need for readable text at smaller font-sizes, but also produces tighter leading on headings.

Kirtishukla2004 added a commit to Kirtishukla2004/modern-css-reset that referenced this issue Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants