Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talkgroup Names and Link to Hose #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rbp9bc
Copy link

@rbp9bc rbp9bc commented Jan 21, 2018

Implemented links to the Brandmeister Hose. Displays "Official" name of Talkgroups.

screenshot 2018-01-19 23 23 52

We've had this running on the KC0CDG Missouri S&T Repeater in Rolla, MO for a few days.

rbp9bc and others added 2 commits January 20, 2018 18:14
Implemented links to the Brandmeister Hose. Displays "Official" name of Talkgroups.
Don't know where those came from? removed bad lines from end of file
@AndyTaylorTweet
Copy link
Owner

There are two fundamental problems with this commit;

The TG name data is static, it's not referenced to BrandMeister, so if the name changes, the dashboard will be out of date.

The second problem is that it does not account for anyone using non-BrandMeister network(s), where the TG number may be duplicated but with a quite different name / use.

@rbp9bc
Copy link
Author

rbp9bc commented Jan 21, 2018

  1. Names won't change that often and I have a 2 line bash script that can update the list but this isn't the repo for that file.

  2. It can be tied into the already existing configuration file that has selected a BM host

@AndyTaylorTweet
Copy link
Owner

So you would prefer this to not work for DMRGateway users too? For me to add a feature like this (don't mis-understand I do like it) - it has to work in all cases, it would be a shame to only have it work on BM only mode.

@JDogHerman
Copy link
Contributor

JDogHerman commented Jan 26, 2018

Why not only display these when BM is enabled and pull the list from the Brandmeister API maybe on init?

https://api.brandmeister.network/v1.0/groups/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants