Allow using external gtest with GTest:: qualified names #737
Conversation
|
Thanks for the PR David. |
Well, I saw the option USE_EXTERNAL_GTEST, so I turned it on and pointed CMake to my own installation of GTest v1.12.1 using the GTest_DIR CMake variable so find_package could find it, and ..... It uses different names for its libraries in the v1.12.1 installation than you have in this CMakeLists.txt file. So I patched it like this to use either flavor of names for the gtest libraries. If the option exists to use an external GTest, then it seems to me that it should work after the find_package call successfully finds it. Once everything was built correctly, all the test passed flawlessly. And all the examples worked great. Kudos on that! Love using a project where everything just works once it's built! |
|
Is there a way not to have google test as a git submodule? because if I already have gtest or if I don't want testing, still |
I'll have to leave that question to those with a better understanding of google test. |
* remotes/origin/main: Minor code tidy Added CLIPPER2_HI_PRECISION option in CMakeLists.txt Additional minor tweaks to cpp/benchmark tests Make googletest not be a git submodule, and instead clone it separately in the CI script (AngusJohnson#745) fix compiler warning of -Wunused-but-set-parameter with -fno-exceptions (AngusJohnson#744) Additional tweaks to GetIntersectPtBenchmark.cpp Additional GetIntersectPtBenchmark tweaks Fixed incorrect code comment Added new GetIntersectPoint benchmark test Updated other benchmark tests. Code formatting only (removed trailing spaces) Fixed minor typecasting issues (AngusJohnson#727) More tweaks to PointInPolygon benchmarking. Allow using external gtest with GTest:: qualified names (AngusJohnson#737) Fixed a significant (though uncommon) bug in polygon clipping (AngusJohnson#736) Fixed bugs in PointInPolygon benchmark testing. Minor tweaks to PointInPolygon benchmark testing. Fixed a minor syntax error tripping some C++ compilers Version 1.3.0 1. Fixed a significant offsetting bug introduced in previous update (AngusJohnson#733) 2. Fixed a C++ compile error when 32bit compiling (AngusJohnson#727) 3. Minor tweak to CMakeLists.txt (C++) (AngusJohnson#728) 4. Will now offset 'flat' polygons (Disc.AngusJohnson#725) 5. Reminder: recent change in open path offsetting behaviour (AngusJohnson#707) 6. Reminder: recent changes to clipper.export.h data structures. Fixed a typo and tweaked documentation Version 1.2.4 Changes since ver 1.2.3 include: 1. Important: Offsetting open path behaviour has changed. The delta now behaves as it did in Clipper1 (See Issue AngusJohnson#707) 2. Important: Data structures of exported values in clipper.export.h have changed. 3. Minor bugfixes to PolyTree nesting (AngusJohnson#679, AngusJohnson#687) 4. Numerous minor bugfixes to polygon offsetting (AngusJohnson#703, AngusJohnson#715, AngusJohnson#724) 5. Fixed an obscure bug in polygon clipping caused by horizontal spikes (AngusJohnson#720) 6. Significantly improved documentation. Additional minor bugfix to ClipperOffset (AngusJohnson#724 & Disc.AngusJohnson#726)
No description provided.