Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaked instances on exit #1

Open
AnidemDex opened this issue Apr 29, 2021 · 9 comments
Open

Leaked instances on exit #1

AnidemDex opened this issue Apr 29, 2021 · 9 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@AnidemDex
Copy link
Owner

For some reason, the plugin doesn't clean itself and its resources even if I free it at exit.
This may be due godotengine/godot#45512 (wich will be fixed on 4.0) but I'm not sure. For now it's not generating a major problem, but I should keep track of this.
@AnidemDex AnidemDex added bug Something isn't working wontfix This will not be worked on labels Apr 29, 2021
@AnidemDex
Copy link
Owner Author

Update: for some unknow reason, i managed to solve this. I really don't know how I did it

@AnidemDex
Copy link
Owner Author

Another Update: Translations inspector added this bug again. Maybe the plugin inspector can't be free at exit since someone is still holding it's reference?

Annotation: maybe i should use weakref to editor plugins

@AnidemDex AnidemDex changed the title Leaked instences on exit Leaked instances on exit May 6, 2021
@AnidemDex
Copy link
Owner Author

Apparently fixed. Don't instance or reference resources without freeing them

@AnidemDex
Copy link
Owner Author

v0.1.4 added this issue again, with a misterious PanelContainer that appears randomly

@AnidemDex AnidemDex reopened this May 10, 2021
@AnidemDex
Copy link
Owner Author

v0.1.4 added this issue again, with a misterious PanelContainer that appears randomly

Apparently, drag & drop function causes this

@AnidemDex
Copy link
Owner Author

v0.2.0 update: The issue is gone.

I'm not closing this just in case.

@AnidemDex
Copy link
Owner Author

v0.3 update: Still no leaked instances

Pro tip: Be sure to free any unused instance.

@AnidemDex
Copy link
Owner Author

More information: godotengine/godot#21461

@AnidemDex
Copy link
Owner Author

v1.0 update: No leaked instances.
Another tip: Use signals to avoid orphan nodes.

gitbook-com bot pushed a commit that referenced this issue Nov 17, 2021
@AnidemDex @gitbook-bot
GitBook: [#1] Add changelog page
bb676b9
AnidemDex added a commit that referenced this issue Nov 17, 2021
@AnidemDex
Revert "GitBook: [#1] Add changelog page".
c0dd957 
This reverts commit bb676b9 because it removed changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AnidemDex