Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate types to v9 #120

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Migrate types to v9 #120

merged 3 commits into from
Apr 26, 2022

Conversation

Linkaynn
Copy link
Contributor

Finally, I found some time to migrate the types of Foundry VTT 9. Here it is.

Some change notes:

  • For some reason, Foundry doesn't maintain the support of the tabs style, so I have to re-write some style code, not a big deal.
  • The damage calculator was the "big" change. I said "big" because was just a few lines of code.

I tested in my current campaign world and everything works fine.

@Linkaynn Linkaynn self-assigned this Apr 25, 2022
@Linkaynn Linkaynn requested a review from a team April 25, 2022 19:29
@Linkaynn Linkaynn linked an issue Apr 25, 2022 that may be closed by this pull request
[🇪🇸 - Feature request] Intentar upgradear los tipos a la versión 9 #114
Closed
@Linkaynn Linkaynn mentioned this pull request Apr 25, 2022
Merged
@Linkaynn Linkaynn merged commit 5315ac1 into main Apr 26, 2022
@Linkaynn Linkaynn deleted the migrate_to_v9 branch April 26, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guote Guote Guote approved these changes

Assignees

@Linkaynn Linkaynn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🇪🇸 - Feature request] Intentar upgradear los tipos a la versión 9
2 participants
@Linkaynn @Guote