Variable open and fumble range #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sheet; fumble range and openRoll range. ABFEExploderRoll will use this values when available instead of DEFAULT_FUMBLE_RANGE and DEFAULT_OPEN_RANGE. When rolling an ability > 200 the fumble range decreases by 1.
… '1d100Initiative'
…can be checked if an ABFFoundryRoll fumbled and it is included in the combat attack hook (but it's not being used yet), a fumble in Initiative will deduct 75/100/125 AND the value of the first roll, and combatants who got a fumble are put on the bottom of initiative even if their final initiative is not the lowest.
…astery the word 'mastery' must be included in the formula
Linkaynn
approved these changes
May 7, 2022
src/module/combat/ABFCombat.ts
Outdated
| a: Combatant, | ||
| b: Combatant | ||
| ): number { | ||
| var initiativeA = a.initiative || -9999; |
| @@ -231,8 +234,14 @@ export class CombatAttackDialog extends FormApplication<FormApplicationOptions, | |||
|
|
|||
| const counterAttackBonus = this.data.attacker.counterAttackBonus ?? 0; | |||
|
|
|||
| //const complexWeapon = (weapon?.data.special.value.includes("Compleja")); | |||
There was a problem hiding this comment.
Se te colo un comentario por aquí
| } | ||
|
|
||
| //const complexWeapon = (weapon?.data.special.value.includes("Compleja")); |
| })); | ||
|
|
||
| this.foundryRoll.recalculateTotal(); | ||
|
|
||
| // if (this.fumbled) { | ||
| // this.foundryRoll.recalculateTotal(this.calculateFumbledMod()-this.foundryRoll.firstResult); |
There was a problem hiding this comment.
No los quería quitar porque pensé que se podría usar en el futuro
There was a problem hiding this comment.
No pasa nada, en git se queda registrado. ¡Gracias por el curro!
Co-authored-by: Jesé Romero Arbelo <jeseromeroarbelo@gmail.com>
Co-authored-by: Jesé Romero Arbelo <jeseromeroarbelo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Added fields to modify the range of open and fumbled rolls.
The ActorData is now included with all 1d100xa rolls so the ranges can be checked.
Changed all instances of 1d100xaturn to 1d100Initiative.
If an ability with a base value above 200 is rolled the fumble range goes down by 1 (unless the range was already 1 or lower).
ABFFoundryRoll has a getter called fumbled that checks if the roll is a fumble.
In combat, the attack hook now includes a boolean indicating if it was a fumble (unused for now).
The fumble modifiers for Initiative rolls now include the value of the first roll, so it adds up to (Initiative - fumble) instead of (initiative + first roll - fumble).
Tweaked the initiative sorting so that a characters that fumble are allways at the bottom of the initiative, even if their final initiative is not the lowest.