Add a Migration system and fix #172 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traduction du fichier migrations.md (#184 )
|
Hello ! |
Yes, right ! I did'nt thought of it this way. :) Co-authored-by: Aitor Balmaseda <32964371+Eryx5502@users.noreply.github.com>
documentation FR pour migrations.md
Linkaynn
approved these changes
Nov 24, 2023
Comment on lines
+18
to
+22
| if (game.settings.get('animabf', ABFSettingsKeys.DEVELOP_MODE)) { | ||
| console.warn( | ||
| `AnimaBF | Migration ${migration.version} needs not to be applied, current system migration version is ${currentVersion}.` | ||
| ); | ||
| } |
|
Lo unico que me "preocupa" son los ficheros que están en |
This is needed for migrations creating/deleting (inner) items from the actor, for instance.
3 tasks
There was a problem getting the updateData with `.toObject()` from the modified actor. When modifying the actor inplace without calling `.update(...)` the actor source (the Document DataSource) is not updated, and `.toObject()` returns the old `actor.system`.
Eryx5502
force-pushed
the
fix/172-enable-fumble-by-default
branch
from
fc496bb to
cd6339a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #172, a migration of the actor data needs to be performed. This led me to introduce a Migration system heavily inspired by Pathfinder's one, yet simplified and applied to our case.
A documentation page (both in Spanish and English has been added, explaining in detail how the system works and how to write new migrations. I didn't feel able to write also the French translation (although I'll be happy to review it if @LIARDM has time for translating).
The functions migrating
itemsandtokensneed still to be written, but I thought it's ok to do that when we have a particular migration for them on mind. Also, the ability to migrate actor data is needed for PR #181, which introduces some urgency.Finally, a migration is added to reassign the properties
system.general.settings.fumbles.valueand thesystem.general.settings.openRolls.value, solving the original issue.