#154: Improve user and profile serialization #166
Conversation
e.g. Profile.status (which has different choices)
In the user serializer, switch from a single nested ProfileSerializer to handling multiple profiles via the `many=True` argument. This allows for a one-to-many relationship between users and profiles. Additionally, in the ProfileSerializer: - Add a read-only user field to represent the reverse relation - Change the phone_number field to a plain string to simplify handling of different formats In the FoodRequest model, rename the `status` field to `request_status` for clarity. Update the magic login page to correctly disable the code input field when no code has been requested yet.
PR Review 🔍(Review updated until commit 442579e)
|
![qodo-merge-pro[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
qodo-merge-pro
bot
added
Review effort [1-5]: 3
and removed
Review effort [1-5]: 2
labels
|
Persistent review updated to latest commit 442579e |
| @@ -119,7 +119,7 @@ async function authHandler() { | |||
| <p class="text-gray-500 dark:text-gray-400 text-center">Don't have an account? <NuxtLink to="/login" class="text-primary font-medium">Sign up</NuxtLink>.</p> | |||
|
|
|||
| <UInput v-model="email" name="email" type="hidden" label="Email" required /> | |||
| <UInput v-model="code" name="code" type="text" color="primary" variant="outline" :disabled="state.code" placeholder="Code" label="Code" size="xl" class="w-32 mx-auto" maxLength="6" required /> | |||
| <UInput v-model="code" name="code" type="text" color="primary" variant="outline" :disabled="state.code !== null" placeholder="Code" label="Code" size="xl" class="w-32 mx-auto" maxLength="6" required /> | |||
There was a problem hiding this comment.
Consider adding a loading spinner or disabling the "Sign In" button while the authentication request is in progress. This can improve user experience by providing feedback that the system is working on their request. [important]
| @@ -96,7 +96,7 @@ class FoodRequest(BaseAbstractModel): | |||
| date_requested = models.DateField(auto_now_add=True) | |||
|
|
|||
| # Request Received, Request Approved & in Queue, Request Denied, Volunteer Assigned, Request Ready For Volunteer Pickup, Delivery Scheduled, Out For Delivery, Delivered, Undeliverable | |||
| status = models.CharField( | |||
| request_status = models.CharField( | |||
There was a problem hiding this comment.
Ensure that all existing data in the status field is correctly migrated to request_status and that any code relying on the status field is updated to use request_status. This is crucial to prevent data loss or inconsistencies during the migration. [important]
| # phone = serializers.CharField(required=False, allow_blank=True) | ||
| profile = ProfileSerializer(required=False) | ||
| # A user can have multiple profiles | ||
| profiles = ProfileSerializer(many=True) |
There was a problem hiding this comment.
Since users can have multiple profiles, ensure that the frontend and any consuming services are updated to handle the profiles field as an array. This may require adjustments in the UI rendering logic and data handling. [important]
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| # Example of a viewset with custom actions. | |||
| # | |||
| class CurrentUserAPIView(CreateAPIView): | |||
| class CurrentUserAPIView(RetrieveAPIView): | |||
There was a problem hiding this comment.
After changing CurrentUserAPIView from CreateAPIView to RetrieveAPIView, ensure that the frontend correctly handles the API response. This change implies that the view now supports GET requests for fetching the current user's data, which might require adjustments in the API consumption logic. [medium]
apps/api/afbcore/migrations/0002_rename_status_foodrequest_request_status.py
Show resolved
Hide resolved
Co-authored-by: codiumai-pr-agent-pro[bot] <151058649+codiumai-pr-agent-pro[bot]@users.noreply.github.com> Signed-off-by: Delano <1206+delano@users.noreply.github.com>
Co-authored-by: codiumai-pr-agent-pro[bot] <151058649+codiumai-pr-agent-pro[bot]@users.noreply.github.com> Signed-off-by: Delano <1206+delano@users.noreply.github.com>
…uest_status.py Co-authored-by: codiumai-pr-agent-pro[bot] <151058649+codiumai-pr-agent-pro[bot]@users.noreply.github.com> Signed-off-by: Delano <1206+delano@users.noreply.github.com>
This pull request includes several changes to improve the user and profile serialization. The changes are as follows:
In the user serializer, switch from a single nested ProfileSerializer to handling multiple profiles via the
many=Trueargument. This allows for a one-to-many relationship between users and profiles.In the ProfileSerializer, add a read-only user field to represent the reverse relation.
Change the phone_number field in the ProfileSerializer to a plain string to simplify handling of different formats.
In the FoodRequest model, rename the
statusfield torequest_statusfor clarity.Update the magic login page to correctly disable the code input field when no code has been requested yet.
Fixes #154.