Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check for scalePivotTranslate when enableReadAnimatedValues is changed #115

Conversation

pmolodo
Copy link
Contributor

@pmolodo pmolodo commented Sep 6, 2018

Description (this won't be part of the changelog)

Fix for the setting of scalePivotTranslate in enableReadAnimatedValues - it was checking scalePivot instead of scalePivotTranslate.

Also, scalePivotTranslate / rotatePivotTranslate are vector values, not points.
Also reverted a change to not use, ie, MVector::zero, per Rob's note here:
#112 (review)

Changelog

Fixed

  • check for whether scalePivotTranslate needs to be set enableReadAnimatedValues was checking if scalePivot was set, not scalePivotTranslate

Checklist (Please do not remove this line)

  • Make sure the Title and Description of the PR make sense and provide sufficient context for your work
  • Do any added files have the correct AL Apache Licence Header?
  • Are there Doxygen comments in the headers?
  • Are any new features, behaviour changes documented in the .md format documentation?
  • Have you added, updated tests to cover new features and behaviour changes?
  • Have you filled out at least one changelog entry?

Copy link
Contributor

@robthebloke robthebloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fabal fabal merged commit c4f4495 into AnimalLogic:develop Sep 19, 2018
@pmolodo pmolodo deleted the pr/fixSetScaleTranslate_in_enableReadAnimatedValues branch October 21, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants