-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to MySQL (Plannetscale) #90
Conversation
this includes a seeding script and db access. i have not yet implemented it into the api
everything seems to be working really well. some sql wizard might be able to speed up my queries but its not the end of the world
First of all, can you configure your editor to use prettier so that it picks up the my configured prettier settings. |
First of all sorry wasn't aware my editor didn't pick up on the prettier config. |
That's alright. As long as the code is still there :) |
FYI, I'm just cleaning up some things before doing a proper review and testing. |
That's fine you do your thing, and I'll do mine |
removed the index's since mysql doesn't support indexing on text columns without a fixed length add sql migration for adding quote_view back for easier querying of quotes
continuation of e88de0d |
After a bit of research it would be possible to generate a "unique" index on the names using a generated column that is a md5 hash of the name or preferably of id+name and lookup that instead. I'll do some testing and see how to implement it and how it would affect the query speeds and the liking |
Note 🔔 |
chore(db): update json data source path
Alright I will wait with my own additions till you have pushed yours and I'll deal with conflicts on my end if there are any |
Good job here @melosh101. There still a lot of areas of improvement in the codebase but I didn't want to make this PR any more complex. Premature optimization is the root of all devils. Anyway Plannetscale is live now 🙌 |
Wohooooooo |
No description provided.