[add] Implementing a more stable Yandex Translate implementation

[ZhymabekRoman]

26.04.2021_18.31.17_REC.mp4

[ZhymabekRoman]

Fixes #4

[ZhymabekRoman]

Oh, my God, I didn't finish something

[ZhymabekRoman]

All right, ready. By the way, I had to remove the transliterating function in Yandex Translator because it does not work

[Animenosekai]

Reviewing Zhymabek Roman's implementation of Yandex.Translate

[Animenosekai]

Thank you very much for your PR!

I just reviewed it and left some comments ~

[ZhymabekRoman]

Thank you for code reviewing and comments, tomorrow with fresh head look all above listed comments in code

[Animenosekai]

[review] I thought I would need to reimplement the SID system just for transliteration but it seems to work fine without it.

That's cool if we don't need it because it removes the file IO time (although I think that it shouldn't be a lot of overhead because the longest IO operation here is the internet request)

[ZhymabekRoman]

[review] I thought I would need to reimplement the SID system just for transliteration but it seems to work fine without it.

Transliteration in Yandex Translator does not require either SID or UCID, that is, transliteration is absolutely free, so it makes no sense to reimplement SID.

[Animenosekai]

[review] I thought I would need to reimplement the SID system just for transliteration but it seems to work fine without it.

Transliteration in Yandex Translator does not require either SID or UCID, that is, transliteration is absolutely free, so it makes no sense to reimplement SID.

Ok cool!

Do you want to make changes or should I merge your PR?

[ZhymabekRoman]

Yes, PR is ready, you can merge.

[Animenosekai]

[merged] Thank you very much!!!

Just tested it by installing the main branch version (using pip install git+https://git url) and it works perfectly!!

[ZhymabekRoman]

Hello, @Animenosekai, Can you enable the discus function in the repository? I just have some thoughts and ideas that I would like to talk about, I don't see the point creating issue for this. Here is the instruction: https://docs.github.com/en/discussions/quickstart

[Animenosekai]

Hello, @Animenosekai, Can you enable the discus function in the repository? I just have some thoughts and ideas that I would like to talk about, I don't see the point creating issue for this. Here is the instruction: https://docs.github.com/en/discussions/quickstart

Added!