fix: JSON Merge Patch test #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - make the script handle the array object for the 'message example object' - "json_pointer":"/components/messages/userSignUp/examples - will have to make it generalized
Changes: - update script to handle array objects at the target location - update spec with jsonPointer to add contents inside the arrays object
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
2 tasks
Changes: - i'm assuming due to the following section of code the replacement was not being done correctly in other places. After replacing it with the earlier logic, it's working and replacing fine and as expected
Changes: - change json pointer from String Reperesentation to URI Fragment Identifier Representation - more info here: https://datatracker.ietf.org/doc/html/rfc6901#section-6 - suggested by Sergio for the sake of consistency
Changes: - combined base doc - attempt to create a combined base doc for better management, instead of having two separate docs
Changes: - modify example, remove line which was causing the error - modufy script to take the new combined doc as the input
Changes: - modify example to match the correct format of the spec - add new sub-heading to denote what kind of OAuth Flow is - applied suggestion from: asyncapi#1059 (comment)
|
Testing done and original PR merged. Closing Ref: asyncapi#1059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test branch to keep the the work separated